Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the support tab's design. #191

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MEMORIEmusic
Copy link

@MEMORIEmusic MEMORIEmusic commented Feb 2, 2025

This PR adds:

  • a new design for the support page
  • faq within the support page
  • links to external resources such as the docs in the support page
  • new links in the Help app menu

Video of the new design:

Screen.Recording.2025-02-05.at.13.13.10.mp4

Help menu bar items:

Screenshot 2025-02-03 at 10 41 48

Embeds the documentation(https://docs.getmythic.app/) into SupportView
Adds the following "Help" menu located in the menu bar:

- Mythic Documentation

- Discord Server Invite

- Github repo

- Changelog

- Link to ko-fi
@MEMORIEmusic MEMORIEmusic changed the title Embedded documentation Embedded documentation and other resources in SupportView and in "Help" item in the menu bar Feb 3, 2025
@MEMORIEmusic MEMORIEmusic reopened this Feb 3, 2025
@MEMORIEmusic
Copy link
Author

accidentally closed the pull request earlier :( please dont mind

@MEMORIEmusic MEMORIEmusic marked this pull request as draft February 3, 2025 07:14
@MEMORIEmusic
Copy link
Author

I will be trying to make this page look nicer. It's kinda a mess and hard on the eyes

- nicer looking UI

- added buttons to the discord guild, github repo, compatibility list, and kofi

- added FAQ
@MEMORIEmusic MEMORIEmusic changed the title Embedded documentation and other resources in SupportView and in "Help" item in the menu bar Complete UI overhaul of SupportView along with embedded documentation & other resources "Help" item in the menu bar Feb 5, 2025
@MEMORIEmusic MEMORIEmusic marked this pull request as ready for review February 5, 2025 11:36
@vapidinfinity
Copy link
Member

that looks fire
will review later at school rn

@MEMORIEmusic
Copy link
Author

that looks fire

will review later at school rn

Thanks! It might be a little janky cause it's my first time doing something in Swift 😅 I'm open to any suggestions!

Copy link
Collaborator

@JoshuaBrest JoshuaBrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the pages design.

  • the contrast ratios between the blue text and the background are not readable.
  • the buttons are much too big. It would be more understandable if it was a mobile device, but this is for computers. Even if it was for mobile, it still is massive.
  • to account for window sizes, some applications just have a max with for the content and center the content.
  • we don't use any of the hover effects found here in macOS generally, so maybe it would be better if it looked more native. Right now it looks very much like a website.
  • I generally wouldn't include FAQ inside the app because that should be found on the website.

Overall, I really don't find that this design fits the goals of mythic.

@JoshuaBrest JoshuaBrest changed the title Complete UI overhaul of SupportView along with embedded documentation & other resources "Help" item in the menu bar feat: update the support tab's design. Feb 9, 2025
@MEMORIEmusic
Copy link
Author

Alright, understood everything other than the last point.

  • I generally wouldn't include FAQ inside the app because that should be found on the website.

Anyone who needs help is more likely to go to the support tab rather than open the website and click a tiny button saying "FAQ" on the top right of the website.

I'll make a second iteration for the page's design after my exams are over(~11th March).

Thank you for the feedback :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants