Trq/gpu multicopy #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8544888b0e8f4105683cb29fc49d0ce9ecb97ad5
Finish gpu multicopy
trquinn
commented
Feb 8, 2024
trquinn
commented
Feb 8, 2024
DataManager::serializeRemoteChunk(): change name of parameter to avoid confusion with a local variable DataManager: Delete unused localParticles attribute Clean up/add documentation Some whitespace cleanup
|
N.B. My last commit was only tested on my laptop. It needs to be tested on an actual GPU. |
|
I'm realizing that all of the tests I've run so far have been with -DHAPI_TRACE enabled. Currently, this fails to build unless that flag is enabled. The CI doesn't catch this since it only does a non-cuda build. On a related note, I'm finding that 'testenergy' fails if HAPI_TRACE is disabled. I tried out a few different commits, and this issue extends at least back to the beginning of September before we started the project. I've only tried this on Frontera, so far, and it appears as if it might be specific to the SMP build (non-SMP works OK). |
Also deleted a superfluous CmiWallTimer() call.
spencerw
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the local data transfer to GPU faster by using multiple threads to copy the data into the buffer.hh