Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#634 Fix empty Draw over/under history list SQL replacements #635

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

tariqksoliman
Copy link
Member

Polygons could not be drawn into new files because sequelize SQL replacements were replacing history = [] into (:history) like () (which is invalid SQL). The change was to set empty history arrays to null such that (:history) then gets replaced to be (null)

The affected only Draw Over and Draw Under.

Bug was introduced in #593

Closes #634

@tariqksoliman tariqksoliman added the bug Something isn't working label Mar 3, 2025
@tariqksoliman tariqksoliman self-assigned this Mar 3, 2025
@tariqksoliman tariqksoliman merged commit 2e3d82b into development Mar 3, 2025
1 check passed
@tariqksoliman tariqksoliman deleted the ts-634 branch March 3, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue creating a new segment feature with draw tool
1 participant