Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image layer type to support GeoTIFF and Cloud Optimized GeoTIFF images #636

Merged
merged 64 commits into from
Mar 4, 2025
Merged

Add image layer type to support GeoTIFF and Cloud Optimized GeoTIFF images #636

merged 64 commits into from
Mar 4, 2025

Conversation

ac-61
Copy link
Contributor

@ac-61 ac-61 commented Mar 3, 2025

This adds a feature to create image layers to support loading GeoTIFF and Cloud Optimized GeoTIFF images using the georaster-layer-for-leaflet library. Color ramps can only be applied to single banded images. There are some issues with loading multiband images (but they can be loaded).

ac-61 added 30 commits October 3, 2024 16:46
@ac-61
Add Image layer type
72f0877
@ac-61
Add image layer
0d2caef
@ac-61
Add georaster-layer-for-leaflet package
7f92e83
@ac-61
Try different package
2b48b3f
@ac-61
Add opacity setting for geotiff image layer
ba1a8c7
@ac-61
Try georaster-layer-for-leaflet v4.1.1-0
4063aa1
@ac-61
Use correct georaster library version
34c4067
@ac-61
Do not fetch entire COG file before loading
63e6aad
@ac-61
Fix COG layer ordering
7f42734
@ac-61
Add variable to hide all values where there is no data
05071ac
@ac-61
Add js-colormaps library
0c4f941
@ac-61
Working color ramp for single band 8bit images
5472e04
@ac-61
Add fillMinMax for single band 8 bit images
f9ad4e0
@ac-61
Support color ramps for single band images
606b3b2
@ac-61
Leaflet v1.5.1 patched with PR 6522
6eb28cd 
Leaflet/Leaflet#6522
@ac-61
Fix opacity issues when zooming
8021d54
@ac-61
Export colormap data variable
5b9f1b7
@ac-61
Add symlink to js-colormaps library
e06e829
@ac-61
Add color ramp selection dropdown for image layers
4bde241
@ac-61
Clear georaster layer cache before updating colors
28c3b8d
@ac-61
Merge remote-tracking branch 'origin/development' into ac-georaster
0512c20
@ac-61
Working on updating image vars to match tile vars
a5a68bf
@ac-61
Merge remote-tracking branch 'origin/development' into ac-georaster
5446fc5
@ac-61
Add helper script to generate list of colormaps from TiTiler and js-c…
79c1fe2 
…olormaps
@ac-61
Add updated js-colormaps to include colormaps from TiTiler
268c8b5
@ac-61
Load TiTler or js-colormap colormaps depending on TiTiler availability
70a4590
@ac-61
Merge remote-tracking branch 'origin/development' into ac-georaster-m…
8b05e46 
…erge-dev
@ac-61
Clear geotiff cache when toggling layer visibility
bd344b9
@ac-61
Remove extraneous import
2daba9a
@ac-61
Add image layer type to IdentifierTool
61c9827
ac-61 added 17 commits February 13, 2025 13:56
@ac-61
Add constant and todo note
108f9e8
@ac-61
Use latest packages
2944567
@ac-61
Clean up code
ec082fc
@ac-61
Merge remote-tracking branch 'origin/development' into ac-georaster
fad9acb
@ac-61
Update generated files
154dc37
@ac-61
Merge remote-tracking branch 'origin/development' into ac-georaster
82c91b2
@ac-61
Merge remote-tracking branch 'origin/development' into ac-georaster
0348baa
@ac-61
Check to if layer has cogTransform parameter before updating
814552a
@ac-61
Fix loading of image layers
4937555
@ac-61
Fix conditions for fillMinMax
0059b26
@ac-61
Show correct image layer if reordering layers in UI
16f96c4
@ac-61
Merge remote-tracking branch 'origin/development' into ac-georaster
0789bf0
@ac-61
Merge remote-tracking branch 'origin/development' into ac-georaster
96ac350
@ac-61
Do not trim whitespace for layer name and units
20a9e32
@ac-61
Undo Leaflet v1.5.1 patched with PR 6522 commit
ed73c93
@ac-61
Only display cogTransform options on single band images
e0d8224
@ac-61
Update docs
4743a24
@ac-61 ac-61 requested review from jtroberts and tariqksoliman March 3, 2025 20:45
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@tariqksoliman
Copy link
Member

Things I changed:

  • Symlinks don't work in Windows so the configure-beta page failed to build until I copied the contents on js-colormaps.js into its own.:
Failed to compile.

SyntaxError: C:\Users\tsoliman\Documents\Projects\MMGIS\configure\src\external\js-colormaps.js: Unexpected token (1:0)
> 1 | ../../../src/external/js-colormaps/js-colormaps.js

tariqksoliman
tariqksoliman approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jtroberts
jtroberts approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@jtroberts jtroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ac-61 ac-61 merged commit df8e02d into development Mar 4, 2025
1 check failed
@ac-61 ac-61 mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtroberts jtroberts jtroberts approved these changes

@tariqksoliman tariqksoliman tariqksoliman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ac-61 @tariqksoliman @jtroberts