Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symlink bug #638

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Fix symlink bug #638

merged 3 commits into from
Mar 4, 2025

Conversation

ac-61
Copy link
Contributor

@ac-61 ac-61 commented Mar 4, 2025 •
edited
Loading

There was a slightly weird commit in #636, where a file was still marked as a symlink, despite not being a symlink.

Current development branch:
Screenshot 2025-03-04 at 2 04 51 PM

This pull request:
Screenshot 2025-03-04 at 2 04 57 PM

@ac-61 ac-61 marked this pull request as ready for review March 4, 2025 21:58
@ac-61 ac-61 requested a review from tariqksoliman March 4, 2025 22:05
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tariqksoliman
tariqksoliman approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. My commit to change that was bad then. Thanks for catching this. If the docker build and push succeeds again, feel free to merge.

@ac-61 ac-61 merged commit e3da8a3 into development Mar 4, 2025
2 checks passed
@ac-61 ac-61 deleted the ac-fix-symlink branch March 4, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariqksoliman tariqksoliman tariqksoliman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ac-61 @tariqksoliman