Skip to content

Commit

Permalink
Consistent display of model and version in model dropdowns (#1111)
Browse files Browse the repository at this point in the history
Ensure model dropdowns always show model + version instead of just model or model + model ID
  • Loading branch information
AaronPlave authored Feb 1, 2024
1 parent cfd8f6b commit f6e06f8
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/components/constraints/ConstraintForm.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@
<option value={null} />
{#each models as model}
<option value={model.id} disabled={!hasModelPermission(model.id, mode, user)}>
{model.name} ({model.id})
{model.name}
(Version: {model.version})
</option>
{/each}
</select>
Expand Down
1 change: 1 addition & 0 deletions src/components/expansion/ExpansionRuleForm.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@
{#each $models as model}
<option value={model.id}>
{model.name}
(Version: {model.version})
</option>
{/each}
</select>
Expand Down
1 change: 1 addition & 0 deletions src/components/expansion/ExpansionSetForm.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@
{#each $models as model}
<option value={model.id} disabled={!hasModelPermission(model.id, user)}>
{model.name}
(Version: {model.version})
</option>
{/each}
</select>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,8 @@
<option value={null} />
{#each models as model}
<option value={model.id} disabled={!hasModelPermission(model.id, mode, user)}>
{model.name} ({model.id})
{model.name}
(Version: {model.version})
</option>
{/each}
</select>
Expand Down
3 changes: 2 additions & 1 deletion src/components/scheduling/goals/SchedulingGoalForm.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,8 @@
<option value={null} />
{#each models as model}
<option value={model.id} disabled={!hasModelPermission(model.id, mode, user)}>
{model.name} ({model.id})
{model.name}
(Version: {model.version})
</option>
{/each}
</select>
Expand Down

0 comments on commit f6e06f8

Please sign in to comment.