Feature/external dataset subscription #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohansen
force-pushed
the
feature/external-dataset-subscription
branch
from
abcdcff to
017bc53
Compare
duranb
requested changes
Jan 9, 2024
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
force-pushed
the
feature/external-dataset-subscription
branch
from
4b6be82 to
cd74b87
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
… use its own flag
…sh the UI for them to appear
cohansen
force-pushed
the
feature/external-dataset-subscription
branch
from
cd74b87 to
2160567
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Fix external resource fetching sim dataset id argument. * Added a query just to get external dataset names to populate view modification * Added a type for our external dataset query and modified the query to use its own flag * Removed fetchingResourcesExternalNames for now * Added a subscription for external datasets so you don't have to refresh the UI for them to appear * Moved resource name gathering code back to the TimelineEditorPanel --------- Co-authored-by: Aaron Plave <aaron.plave@jpl.nasa.gov>
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Fix external resource fetching sim dataset id argument. * Added a query just to get external dataset names to populate view modification * Added a type for our external dataset query and modified the query to use its own flag * Removed fetchingResourcesExternalNames for now * Added a subscription for external datasets so you don't have to refresh the UI for them to appear * Moved resource name gathering code back to the TimelineEditorPanel --------- Co-authored-by: Aaron Plave <aaron.plave@jpl.nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #932.
This PR adds a subscription to the
plan_datasettable and retrieves the metadata for each plan as they're added to the database. The workflow would be:There's a concern about loading large profiles as well so that still works as it used to.