Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Z to convertDoyToYmd to stop local timezone conversion #1094

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

cohansen
Copy link
Contributor

Closes #1087.

Add 'Z' to the return value of convertDoyToYmd so a local timezone conversion doesn't happen.

@cohansen cohansen self-assigned this Jan 22, 2024
@cohansen cohansen requested a review from a team as a code owner January 22, 2024 17:13
@cohansen cohansen force-pushed the bug/sim-activities-table-timezone branch from d57d65f to 5101824 Compare January 23, 2024 16:33
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cohansen cohansen force-pushed the bug/sim-activities-table-timezone branch from 5101824 to 956e4cb Compare January 30, 2024 21:37
@cohansen cohansen merged commit 0efc74f into develop Jan 30, 2024
4 checks passed
@cohansen cohansen deleted the bug/sim-activities-table-timezone branch January 30, 2024 21:50
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* Added Z to convertDoyToYmd to stop local timezone conversion

* Converted to template string
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* Added Z to convertDoyToYmd to stop local timezone conversion

* Converted to template string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulated Activities Table reports incorrect Absolute End Time
2 participants