Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/1088/activity directive creator #1095

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Feat/1088/activity directive creator #1095

merged 3 commits into from
Jan 30, 2024

Conversation

AaronPlave
Copy link
Contributor

Closes #1088

Testing:

  1. Create a plan
  2. Create an activity
  3. Double click on the activity to view it in the Selected Activity panel
  4. Ensure the forms displays a "Created By" field
  5. Login as a different user and modify the activity start time (as admin)
  6. Ensure the activity "Created By" field remains the same and that the "Last Modified By" field reflects the new user.
  7. Ensure "Created By" and "Last Modified By" are available as Activity Directive Table column options.

@AaronPlave AaronPlave requested a review from a team as a code owner January 23, 2024 00:16
@AaronPlave AaronPlave removed the request for review from jeffpamer January 23, 2024 00:16
@AaronPlave AaronPlave self-assigned this Jan 23, 2024
duranb
duranb approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AaronPlave AaronPlave force-pushed the feat/1088/activity-directive-creator branch from a18e537 to a15a9db Compare January 30, 2024 19:31
@AaronPlave AaronPlave force-pushed the feat/1088/activity-directive-creator branch from a15a9db to f83e7a5 Compare January 30, 2024 22:48
@AaronPlave AaronPlave merged commit 8c1e15a into develop Jan 30, 2024
4 checks passed
@AaronPlave AaronPlave deleted the feat/1088/activity-directive-creator branch January 30, 2024 23:04
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@AaronPlave
Feat/1088/activity directive creator (#1095)
5c2f5f5 
* Update ActivityDirective type and gql query to include created_by field
* Add ActivityDirective created_by field to selected activity form and directives table column options
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@AaronPlave @JosephVolosin
Feat/1088/activity directive creator (#1095)
6373ac5 
* Update ActivityDirective type and gql query to include created_by field
* Add ActivityDirective created_by field to selected activity form and directives table column options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@AaronPlave AaronPlave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show activity directive creator in the UI
2 participants
@AaronPlave @duranb