Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit parameter layout issue #1109

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

AaronPlave
Copy link
Contributor

Closes #1104. @duranb you might want to double check this, especially with the ParameterBaseVariant as I'm not exactly sure how to get an example of that.

@AaronPlave AaronPlave requested a review from a team as a code owner January 31, 2024 22:11
@AaronPlave AaronPlave self-assigned this Feb 1, 2024
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you need an example of a variant for future use, the PeelBanana activity is one. It's essentially enums.

@AaronPlave AaronPlave force-pushed the fix/1104/activity-param-formatting-fix branch from 7805cdd to e4b659e Compare February 1, 2024 21:08
@AaronPlave AaronPlave merged commit eba1502 into develop Feb 1, 2024
4 checks passed
@AaronPlave AaronPlave deleted the fix/1104/activity-param-formatting-fix branch February 1, 2024 21:21
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting issue in activity param units
2 participants