Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one day as default plan duration #1110

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Use one day as default plan duration #1110

merged 2 commits into from
Feb 1, 2024

Conversation

AaronPlave
Copy link
Contributor

Closes #1098

Testing:

  1. Go to the plans page
  2. Select a start date
  3. The end date should auto populate with start date + one day even when rolling into the next month and year.

@AaronPlave AaronPlave requested a review from a team as a code owner January 31, 2024 23:23
@AaronPlave AaronPlave self-assigned this Jan 31, 2024
duranb
duranb approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AaronPlave AaronPlave force-pushed the feat/1098/plan-duration-default-one-day branch from c27e7c9 to 0ab805c Compare February 1, 2024 20:57
@AaronPlave AaronPlave merged commit 7a8709c into develop Feb 1, 2024
4 checks passed
@AaronPlave AaronPlave deleted the feat/1098/plan-duration-default-one-day branch February 1, 2024 21:07
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@AaronPlave
Use one day as default plan duration (#1110)
b586dee 
* Use one day as default plan duration
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@AaronPlave @JosephVolosin
Use one day as default plan duration (#1110)
cf8eaf2 
* Use one day as default plan duration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@AaronPlave AaronPlave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide Different Default Plan Duration
2 participants
@AaronPlave @duranb