-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduling Subscription and Canceling #1141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
commented
Mar 4, 2024
AaronPlave
commented
Mar 4, 2024
AaronPlave
commented
Mar 4, 2024
AaronPlave
commented
Mar 4, 2024
duranb
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great! thank you!
463b9c4
to
67922ff
Compare
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* subscribe to scheduling spec and scheduling requests tables * compute scheduling status from a variety of inputs * refactor scheduling effect to be mainly subscription based * cancel current scheduling run from navbar
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* subscribe to scheduling spec and scheduling requests tables * compute scheduling status from a variety of inputs * refactor scheduling effect to be mainly subscription based * cancel current scheduling run from navbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscribe to scheduling runs, refine computation and display of scheduling status, and allow users to cancel the current scheduling request if pending or incomplete.
Changes:
scheduling_requests
table, filtered by current scheduling spec ideffects.schedule
to use a temporary subscription on theschedulingRequests
store (which is now a gql subscription) instead of polling theschedule
actionCloses #1040, closes #1047.
Testing: