Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling Subscription and Canceling #1141

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Mar 1, 2024

Subscribe to scheduling runs, refine computation and display of scheduling status, and allow users to cancel the current scheduling request if pending or incomplete.

Changes:

  • Subscribe to the scheduling_requests table, filtered by current scheduling spec id
  • Subscribe to current scheduling spec
  • Refactor effects.schedule to use a temporary subscription on the schedulingRequests store (which is now a gql subscription) instead of polling the schedule action
  • Display modified status for scheduling when out of date with scheduling spec or plan revision

Closes #1040, closes #1047.

Testing:

  1. Make a plan
  2. Verify that scheduling status in the navbar is not present as no scheduling runs have been performed
  3. Add a scheduling goal to the plan in a new tab that should add activities
  4. Verify that the scheduling status for the plan is marked as modified without having to refresh the page
  5. Run scheduling analysis
  6. Scheduling status should transition to in-progress and then to failure
  7. Inside the plan's scheduling panel the goal should indicate that not all goals were satisfied
  8. Verify that the navbar status on hover indicates 1 unsatisfied goal
  9. Run scheduling
  10. Scheduling status should transition to in-progress and then to success
  11. Refresh the page and ensure that the status remains success
  12. Modify the plan (move an activity)
  13. Re-run scheduling
  14. Ensure that a new simulation is loaded in the UI (check simulation panel) after scheduling completes
  15. Modify the scheduling goal in the other tab
  16. Ensure that the scheduling status is now modified

@AaronPlave AaronPlave self-assigned this Mar 1, 2024
@AaronPlave AaronPlave marked this pull request as ready for review March 1, 2024 01:05
@AaronPlave AaronPlave requested a review from a team as a code owner March 1, 2024 01:05
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great! thank you!

@AaronPlave AaronPlave force-pushed the refactor/1040/scheduling-subscription branch from 463b9c4 to 67922ff Compare March 5, 2024 00:03
@AaronPlave AaronPlave merged commit b665378 into develop Mar 5, 2024
4 checks passed
@AaronPlave AaronPlave deleted the refactor/1040/scheduling-subscription branch March 5, 2024 00:33
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* subscribe to scheduling spec and scheduling requests tables
* compute scheduling status from a variety of inputs
* refactor scheduling effect to be mainly subscription based
* cancel current scheduling run from navbar
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* subscribe to scheduling spec and scheduling requests tables
* compute scheduling status from a variety of inputs
* refactor scheduling effect to be mainly subscription based
* cancel current scheduling run from navbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel Scheduling Schedule Navbar Button is subscribed to incorrect Scheduling Run
2 participants