Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import SATF Library Sequence #1592

Merged
merged 7 commits into from
Feb 3, 2025
Merged

Import SATF Library Sequence #1592

merged 7 commits into from
Feb 3, 2025

Conversation

goetzrrGit
Copy link
Contributor

@goetzrrGit goetzrrGit commented Jan 14, 2025 •
edited
Loading

Closes #1591

Library Sequence Modal:

  • Introduced a new modal for importing a library sequence file.
  • Integrated the library modal with workspaces for seamless interaction.

Linting Bugfix:

  • Fixed an issue where the linter incorrectly reported errors for values within a valid range when multiple ranges were defined.
  • Fixed an issue where the linter incorrectly reported errors for command stems with no arguments.

Autocomplete Bugfix:

  • Improved autocomplete functionality to allow completion even with invalid variable types. The user will be notified of the invalid type within the editor and will need to manually correct it.

SATF/SASF Library

  • Fixed an issue where we were not generating the @model correctly.

TESTING

  • Download the attach file (banana_library.txt)
  • Rename it to banana_library.satf
  • Create a new workspace
  • In the middle panel underneath the 'create sequence' you should see a 'import library'
  • Click on 'import library' and select a parcel and library file ex. banana_library.satf
  • Verify the library gets imported and you see 3 sequences created

banana_library.txt

@goetzrrGit goetzrrGit added feature New feature or request sequencing Anything related to the sequencing domain labels Jan 14, 2025
@goetzrrGit goetzrrGit self-assigned this Jan 14, 2025
@goetzrrGit goetzrrGit requested a review from a team as a code owner January 14, 2025 21:49
@goetzrrGit goetzrrGit requested a review from AaronPlave January 14, 2025 21:49
@cohansen
Copy link
Contributor

Is this branch supposed to merge into #1574? It looks like a lot of the same changes.

@goetzrrGit
Copy link
Contributor Author

Is this branch supposed to merge into #1574? It looks like a lot of the same changes.

Yeah it is branched from 1574 and since that was merged in the first 4 fell off. It should now all be new code

duranb
duranb requested changes Jan 17, 2025
View reviewed changes
duranb
duranb previously requested changes Jan 28, 2025
View reviewed changes
joswig
joswig previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@joswig joswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing sonarqube gate, not inspecting contents

@joswig joswig dismissed stale reviews from duranb and themself January 29, 2025 23:47

testing sonarqube

duranb
duranb approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you!

goetzrrGit and others added 7 commits February 3, 2025 04:39
@goetzrrGit
Bugfix allow for paths in Headers
6b4fb8f
@goetzrrGit
Library Sequence Modal
eb5cf14 
This modal allows you to select a parcel and import a library sequence file
@goetzrrGit
Hook up the library modal to workspaces
67e5d54
@goetzrrGit
Fixed incorrect linting errors when multiple ranges are defined.
283d571 
The linter incorrectly reported errors for values within a valid range when multiple ranges were defined. For example, if the ranges were 5-10 and 11-20, the linter would erroneously flag the value 8 as invalid because it falls outside the 11-20 range, even though it is valid within the 5-10 range.
@goetzrrGit
Improved autocomplete functionality by allowing completion even with …
6ab69b9 
…invalid variable types.

Allow autocomplete to succeed and show the ERROR parameter value. The user will see this error in the editor and manually have to fix it.
@goetzrrGit
Fix @model generation.
faa9d4c 
There shouldn't be any parenthesis and commas in the SeqN generation
@duranb @goetzrrGit
fix buttons wrapping
7fe172b
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@goetzrrGit goetzrrGit merged commit ebfaa3a into develop Feb 3, 2025
5 of 6 checks passed
@goetzrrGit goetzrrGit deleted the import_satf_library branch February 3, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joswig joswig joswig left review comments

@duranb duranb duranb approved these changes

@cohansen cohansen Awaiting requested review from cohansen

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@goetzrrGit goetzrrGit

Labels
feature New feature or request sequencing Anything related to the sequencing domain
Projects
Aerie
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import SATF Library Sequences Prototype
4 participants
@goetzrrGit @cohansen @duranb @joswig