Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Phoenix Editor linting changes #1629

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Feb 12, 2025

This applies some eslint fixes to Phoenix editor util files.

@duranb duranb requested a review from a team as a code owner February 12, 2025 20:48
removed `maxItems` from SearchableDropdown now that it is virtualized
first pass linting
@duranb duranb force-pushed the refactor/phoenix-linting branch from eb60424 to 8b03649 Compare February 13, 2025 21:40
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@joswig joswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I have limited cognizance around around src/utilities/codemirror/satf/satf-sasf-utils.ts, but the changes are variable renames and they line up

@duranb duranb merged commit f9e092e into develop Feb 14, 2025
5 of 6 checks passed
@duranb duranb deleted the refactor/phoenix-linting branch February 14, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants