From eefc899d3de8706feb2af4556d8c5e5000e19b0c Mon Sep 17 00:00:00 2001 From: Jamie V Date: Tue, 21 Jan 2025 13:43:29 -0800 Subject: [PATCH] fixing tests --- src/exportDataAction/ExportDataTaskSpec.js | 3 +-- .../test/MCWSPersistenceProviderSpec.js | 21 +++++++------------ 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/src/exportDataAction/ExportDataTaskSpec.js b/src/exportDataAction/ExportDataTaskSpec.js index cbb46e8..5e3bc7e 100644 --- a/src/exportDataAction/ExportDataTaskSpec.js +++ b/src/exportDataAction/ExportDataTaskSpec.js @@ -62,9 +62,8 @@ define([ describe('when invoked', () => { - beforeEach(async (done) => { + beforeEach(async () => { await task.invoke(); - done(); }); it('requests comprehensive telemetry for all objects', () => { diff --git a/src/persistence/test/MCWSPersistenceProviderSpec.js b/src/persistence/test/MCWSPersistenceProviderSpec.js index 5a9132e..35afeae 100644 --- a/src/persistence/test/MCWSPersistenceProviderSpec.js +++ b/src/persistence/test/MCWSPersistenceProviderSpec.js @@ -56,14 +56,13 @@ describe('The MCWS Persistence Provider', () => { ); }); - it('provides a promise for available namespaces', async (done) => { + it('provides a promise for available namespaces', async () => { const spaces = await mcwsPersistenceProvider.getPersistenceNamespaces(); expect(spaces).toEqual(persistenceNamespaces); - done(); }); // DO WE DELETE THIS TEST? I don't think we use this functionality anymore. - xit('provides a listing of namespaces when provided a namespace definition', async (done) => { + xit('provides a listing of namespaces when provided a namespace definition', async () => { const namespaceTriples = [ { Subject: '/test/namespace/a', @@ -95,10 +94,9 @@ describe('The MCWS Persistence Provider', () => { const objects = await mcwsPersistenceProvider.getNamespacesFromMCWS({ url: '/test/namespace' }); expect(objects).toEqual(namespaceTriples); - done(); }); - it('allows objects to be created', async (done) => { + it('allows objects to be created', async () => { mockOpaqueFile.create.and.returnValue(Promise.resolve(true)); const domainObject = { identifier: { @@ -114,10 +112,9 @@ describe('The MCWS Persistence Provider', () => { .toHaveBeenCalledWith('testKey'); expect(mockOpaqueFile.create) .toHaveBeenCalledWith({ someKey: 'some value' }); - done(); }); - it('allows objects to be read', async (done) => { + it('allows objects to be read', async () => { const identifier = { key: 'testKey', namespace: 'testSpace' @@ -139,10 +136,9 @@ describe('The MCWS Persistence Provider', () => { .toHaveBeenCalledWith('testKey'); expect(mockOpaqueFile.read) .toHaveBeenCalled(); - done(); }); - it('allows objects to be updated', async (done) => { + it('allows objects to be updated', async () => { mockOpaqueFile.replace.and.returnValue(Promise.resolve(true)); const domainObject = { identifier: { @@ -160,11 +156,10 @@ describe('The MCWS Persistence Provider', () => { .toHaveBeenCalledWith('testKey'); expect(mockOpaqueFile.replace) .toHaveBeenCalledWith({ someKey: 'some value' }); - done(); }); // We don't allow delete in the core API, so we don't need this test. - xit('allows objects to be deleted', async (done) => { + xit('allows objects to be deleted', async () => { mockOpaqueFile.remove.and.returnValue(Promise.resolve(true)); await mcwsPersistenceProvider.delete({ key: 'testKey', namespace: 'testSpace' }); @@ -173,14 +168,12 @@ describe('The MCWS Persistence Provider', () => { expect(mockNamespace.opaqueFile) .toHaveBeenCalledWith('testKey'); expect(mockOpaqueFile.remove).toHaveBeenCalled(); - done(); }); - it('converts rejected promises to promises resolves to undefined', async (done) => { + it('converts rejected promises to promises resolves to undefined', async () => { mockOpaqueFile.read.and.returnValue(Promise.reject('hello')); const result = await mcwsPersistenceProvider.get({ key: 'testKey', namespace: 'testSpace' }); expect(result).toBeUndefined(); - done(); }); });