fixed additional bug where comet designations were being interpreted as packed asteroid desigs

Fixed additional bug where a provisional comet designation with no forward slash and no spaces (e.g., "P2015XN77") was being interpreted as a packed asteroid designation (using only the "P2015" portion of the designation, which is technically unpackable into "252015"), but now raises a TargetNameParseError with the addition of a check to make sure a detected packed designation is not just a portion of a longer input string.

Author: hhsieh00

CHANGES.rst

@@ -35,12 +35,18 @@ sbpy.names
   cometary designations with fragment specifiers (e.g., "2024 A-A" and
   "2024 A-AA" now correctly raise TargetNameParseError exceptions) [#417]
 
-- Fixed `sbpy.Names.parse_comet(()' to raise an error in cases of a
+- Fixed `sbpy.Names.parse_comet()' to raise an error in cases of a
   provisional asteroid designation submitted with no space after the
   year (e.g., "2015XN77"), which was previously being interpreted as a
   well-formed comet designation (i.e., with number=2015, type=X, and
   name=N77), but now raises a TargetNameParseError [#422]
 
+- Fixed `sbpy.Names.parse_asteroid()' to raise an error in cases of a
+  provisional comet designation submitted with no forward slash between
+  the lead character and the year, and no space after the year (e.g.,
+  "P2015XN77"), which was previously being interpreted as a packed
+  asteroid designation, but now raises a TargetNameParseError [#422]
+
 0.5.0 (2024-08-28)
 ==================
 

sbpy/data/names.py

@@ -588,7 +588,7 @@ def parse_asteroid(s):
                     ident = el[4]
                     r['desig'] = Names.from_packed(ident)
                 # packed number
-                elif len(el[5]) > 0:
+                elif len(el[5]) > 0 and len(el[5]) == len(raw):
                     ident = el[5]
                     r['number'] = Names.from_packed(ident)
                 # number

sbpy/data/tests/test_names.py

@@ -274,6 +274,9 @@ def test_parse_asteroid():
     with pytest.raises(TargetNameParseError):
         Names.parse_asteroid('J1')
 
+    with pytest.raises(TargetNameParseError):
+        Names.parse_asteroid('P2015XN77')
+
 
 def test_break_packed():
     with pytest.raises(TargetNameParseError):