Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another dtypes and Windows bug #89

Closed
JavadocMD opened this issue Feb 8, 2024 · 1 comment · Fixed by #90
Closed

Yet another dtypes and Windows bug #89

JavadocMD opened this issue Feb 8, 2024 · 1 comment · Fixed by #90
Assignees
Labels
bug Something isn't working

Comments

@JavadocMD
Copy link
Contributor

As reported by our new Windows users, initializer.py is raising an Exception (seemingly when running some of the basic examples?) related to numpy int64/int32 mismatches.

image

This is likely caused by Windows interpreting np.integer differently than other platforms. np.floating is also problematic, and initializer.py is using both.

@JavadocMD JavadocMD added the bug Something isn't working label Feb 8, 2024
@JavadocMD JavadocMD self-assigned this Feb 8, 2024
@JavadocMD
Copy link
Contributor Author

JavadocMD commented Feb 8, 2024

Believe this was my oversight, thinking I could use np.integer and np.floating to accept any integral or any decimal numbers (respectively). But with more research they clearly do not function that way; it just happened to work for the cases I'd tried thus far.

For the time being, I'll make these checks more strict -- replacing them with np.int64 and np.float64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant