Major data types and attributes refactoring. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we were specifying data types had some flaws. This should be better. Each module had its own way of declaring attributes. This has now been unified which should make future work easier. We also gave some thought to organizing to be less prone to circular import problems.
meaghan66
pushed a commit
that referenced
this pull request
Jun 6, 2024
The way we were specifying data types had some flaws. This should be better. Each module had its own way of declaring attributes. This has now been unified which should make future work easier. We also gave some thought to organizing to be less prone to circular import problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were specifying data types had some flaws. This should be better. Each module had its own way of declaring attributes. This has now been unified which should make future work easier. We also gave some thought to organizing to be less prone to circular import problems.