Class-based syntax revamp: IPM/MM/ADRIOs #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimFunctions now have access to the geo scope.
Adrio2 classes for acs5 attributes.
Adrio2 classes for csv file loading.
Adrio2 class for acs5 commuting flows attribute.
Adrio2 classes for cdc attributes.
TODO: update devlogs, etc.
Now the ADRIO author can decide if caching is appropriate for the use-case. Cache invalidation is more sophisticated now; a caching ADRIO will check, e.g., that its requirements values haven't changed.
Update cdc devlog for adrio2 refactor.
Lists are unhashable, but AttributeDef needs to be. We now require they be tuples, and will convert to lists when needed for numpy.
* LODES adrio2 refactor. * Minor issues addressed in LODES.
Moved adrios. Changed cache CLI command; not geo specific anymore.
Most notably: cache paths have been updated to match module paths. ACS5 ADRIOs validate the scope year.
Rather than set context every tick, we can do it once at the start.
Rather than attaching events to a Simulator, we now use a singleton EventBus. Implemented ADRIO messaging using events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of this branch is a bit misleading; it has grown to encompass all class-based syntax rewrite work.
That work is nearing completion so I wanted to open this PR to track it.
Remaining: