Refactor decrypt function #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pahatz
reviewed
Jan 9, 2024
aaperis
reviewed
Jan 10, 2024
jbygdell
force-pushed
the
refactor_decrypt
branch
from
0c74905 to
ba0f87c
Compare
pontus
approved these changes
Jan 15, 2024
Test reading a public key instead of a private one
Use a passphrase protected file and test with both correct and wrong passphrase.
Unless it can be closed by another thread
This way we can separate the main function form the worker function
This way we don't get prompted for the passphrase in the test.
Aything the user needs to se shuld be printed directly to the correct output channel.
jbygdell
force-pushed
the
refactor_decrypt
branch
from
ba0f87c to
c34b53d
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 51.06% 52.83% +1.76%
==========================================
Files 9 9
Lines 1218 1183 -35
==========================================
+ Hits 622 625 +3
+ Misses 522 479 -43
- Partials 74 79 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
C4GH_PASSWORDis set--force-overwriteoptionHow to test
sda-cli decrypt -key KEY FILE
sda-cli decrypt -key KEY --force-overwrite FILE