Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renew testsuite tokens #341

Merged
merged 1 commit into from
Feb 13, 2024
Merged

renew testsuite tokens #341

merged 1 commit into from
Feb 13, 2024

Conversation

aaperis
Copy link
Contributor

@aaperis aaperis commented Feb 12, 2024

Related issue(s) and PR(s)
Tests fail because of an expired test token e.g. #338, #339, #340

Description
Replaced it with a 5y one from our mockoidc. Note: code generated jwts on the fly, is out of scope for this quick fix.

How to test
go test ./...

@aaperis aaperis requested a review from a team February 12, 2024 18:56
@aaperis aaperis added the bug Something isn't working label Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bb22cc) 52.83% compared to head (e467a72) 52.83%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   52.83%   52.83%           
=======================================
  Files           9        9           
  Lines        1183     1183           
=======================================
  Hits          625      625           
  Misses        479      479           
  Partials       79       79           
Flag Coverage Δ
unittests 52.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaperis aaperis force-pushed the bugfix/renew-testsuite-access-token branch from 59790c3 to e467a72 Compare February 12, 2024 19:01
Copy link
Contributor

@jbygdell jbygdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased on top of main

@aaperis aaperis force-pushed the bugfix/renew-testsuite-access-token branch from e467a72 to 7b393e1 Compare February 13, 2024 18:42
@aaperis aaperis merged commit 7d129c0 into main Feb 13, 2024
6 checks passed
@aaperis aaperis deleted the bugfix/renew-testsuite-access-token branch February 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants