[list] use pagination to list s3 objects #513
Draft
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adjust upload.go accordingly
aaperis
force-pushed
the
feature/pagination-of-list-files
branch
from
a143d84 to
48af8cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #502 .
Description
Overall functionality remains unchanged but now the
ListFilesfunction checks to see if there are more than the returned results and makes subsequent calls until it retrieves all the object info.How to test
Upload 1001 files in a bucket and try to list with sda-cli.
Note:
This is a draft until I figure out a nice way to add tests.
I am considering to expose the
MaxKeysaws configuration option as an argument to the above function so that I can add some sort of unit testing as well.