Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add favicon #948

Merged
merged 1 commit into from
Jul 5, 2024
Merged

feat: add favicon #948

merged 1 commit into from
Jul 5, 2024

Conversation

AnnikaSonnek
Copy link
Contributor

@AnnikaSonnek AnnikaSonnek commented Jul 3, 2024

Related issue(s) and PR(s)

This PR closes #860

Type of change

  • New feature (non-breaking change which adds functionality)

List of changes made

  • Added favicon

Screenshot of the fix

image

Testing

Check out this branch and make a hard reload or clear the cache if necessary. Make sure the icon is there.

Additional questions

The icon is quite detailed and might be hard to see. Do we think that the icon is sufficient? @viklund

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@AnnikaSonnek AnnikaSonnek merged commit 736f976 into develop Jul 5, 2024
10 checks passed
@AnnikaSonnek AnnikaSonnek deleted the feat/add-favicon branch July 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicon
2 participants