Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: add urdr-image to login-page #953

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Style: add urdr-image to login-page #953

merged 2 commits into from
Aug 22, 2024

Conversation

AnnikaSonnek
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #949

Type of change

  • New feature (non-breaking change which adds functionality)

List of changes made

  • Added image to login-page.

Screenshot of the fix

image

Testing

Check out this branch and have a look at the image.

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, I have some suggestions that I would like you to check.

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, looks great!

@KattisLej KattisLej merged commit 22d2a52 into develop Aug 22, 2024
11 checks passed
@KattisLej KattisLej deleted the 949-add-urdr-icon branch August 22, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add urdr icon to the login page
2 participants