Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes to seaice notebooks for new variables grid_file and path_nsidc. #169

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

dabail10
Copy link
Collaborator

Description of changes:

  • Have you followed the guidelines in our Contributor's Guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you made sure that the pre-commit checks passed (#8 in Adding Notebooks Guide)?
  • Have you hidden the code cells (#8 in Adding Notebooks Guide) in your notebook?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully tested your changes locally?
  • Have you moved any observational data that you are using to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data and ensured that it follows this format within that directory: COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?

Hemis_seaice_visual_compare_contour:
parameter_groups:
none:
climo_nyears: 35
grid_file: '/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc'
path_nsidc: '/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Hemis_seaice_visual_compare_contour.ipynb uses NSIDC data, so we don't need to set path_nsidc

Comment on lines +72 to +73
"grid_file = \"/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc\"\n",
"path_nsidc = \"/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent\"\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think grid_file and path_nsidc are repeated in the cell now?

climo_nyears = 35
grid_file = "/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc"
path_nsidc = "/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent"

lc_kwargs = {}

hist = 0

path_nsidc = "/glade/campaign/cesm/development/pcwg/ice/data/NSIDC_SeaIce_extent"
grid_file = "/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc"

If I'm reading the diff right, the second and third lines are your new additions to this notebook while the last two lines were already there from #168. It looks like I left the old default for path_nsidc (/glade/campaign/cesm/development/pcwg/ice/data/NSIDC_SeaIce_extent instead of the sudirectory of /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data that's used in the config.yml file for key_metrics); I'm all for updating to the new value, but can we either update path_nsidc where it was already declared or remove the old declarations of grid_file and path_nsidc down below?

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mnlevy1981 mnlevy1981 merged commit 665084c into NCAR:main Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants