-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes to seaice notebooks for new variables grid_file and path_nsidc. #169
Conversation
examples/coupled_model/config.yml
Outdated
Hemis_seaice_visual_compare_contour: | ||
parameter_groups: | ||
none: | ||
climo_nyears: 35 | ||
grid_file: '/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc' | ||
path_nsidc: '/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Hemis_seaice_visual_compare_contour.ipynb
uses NSIDC data, so we don't need to set path_nsidc
"grid_file = \"/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc\"\n", | ||
"path_nsidc = \"/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent\"\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think grid_file
and path_nsidc
are repeated in the cell now?
climo_nyears = 35
grid_file = "/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc"
path_nsidc = "/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent"
lc_kwargs = {}
hist = 0
path_nsidc = "/glade/campaign/cesm/development/pcwg/ice/data/NSIDC_SeaIce_extent"
grid_file = "/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc"
If I'm reading the diff right, the second and third lines are your new additions to this notebook while the last two lines were already there from #168. It looks like I left the old default for path_nsidc
(/glade/campaign/cesm/development/pcwg/ice/data/NSIDC_SeaIce_extent
instead of the sudirectory of /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data
that's used in the config.yml
file for key_metrics
); I'm all for updating to the new value, but can we either update path_nsidc
where it was already declared or remove the old declarations of grid_file
and path_nsidc
down below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of changes:
pre-commit
checks passed (#8 in Adding Notebooks Guide)?/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data
and ensured that it follows this format within that directory:COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE
?