Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes to seaice notebooks for new variables grid_file and path_nsidc. #169

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Add changes to seaice notebooks for new variables grid_file and path_nsidc. #169

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
889cdb4
Update notebooks to use grid_file and path_nsidc
dabail10 Jan 27, 2025
1bdc4bc
Fix some formatting
dabail10 Jan 27, 2025
d68d362
Remove path_nsidc from contour plots for now
dabail10 Jan 28, 2025
59f32ab
Fix redundant use of grid_file and path_nsidc
dabail10 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/coupled_model/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,14 @@ compute_notebooks:
parameter_groups:
none:
climo_nyears: 35
grid_file: '/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc'
path_nsidc: '/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent'
Hemis_seaice_visual_compare_contour:
parameter_groups:
none:
climo_nyears: 35
grid_file: '/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc'
path_nsidc: '/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Hemis_seaice_visual_compare_contour.ipynb uses NSIDC data, so we don't need to set path_nsidc



########### JUPYTER BOOK CONFIG ###########
Expand Down
4 changes: 3 additions & 1 deletion nblibrary/ice/Hemis_seaice_visual_compare_contour.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@
"base_end_date = \"0100-01-01\"\n",
"\n",
"climo_nyears = 35\n",
"grid_file = \"/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc\"\n",
"path_nsidc = \"/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent\"\n",
"\n",
"lc_kwargs = {}\n",
"\n",
Expand Down Expand Up @@ -161,7 +163,7 @@
" coords=\"minimal\",\n",
").sel(time=slice(base_start_date, base_end_date))\n",
"\n",
"ds_grid = xr.open_dataset(\"/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc\")\n",
"ds_grid = xr.open_dataset(grid_file)\n",
"TLAT = ds_grid[\"TLAT\"]\n",
"TLON = ds_grid[\"TLONG\"]\n",
"tarea = ds_grid[\"TAREA\"] * 1.0e-4\n",
Expand Down
2 changes: 2 additions & 0 deletions nblibrary/ice/Hemis_seaice_visual_compare_obs_lens.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
"base_end_date = \"0101-01-01\"\n",
"\n",
"climo_nyears = 35\n",
"grid_file = \"/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc\"\n",
"path_nsidc = \"/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent\"\n",
Comment on lines +72 to +73
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think grid_file and path_nsidc are repeated in the cell now?

climo_nyears = 35
grid_file = "/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc"
path_nsidc = "/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/hemispheric_data/NSIDC_SeaIce_extent"

lc_kwargs = {}

hist = 0

path_nsidc = "/glade/campaign/cesm/development/pcwg/ice/data/NSIDC_SeaIce_extent"
grid_file = "/glade/campaign/cesm/community/omwg/grids/tx2_3v2_grid.nc"

If I'm reading the diff right, the second and third lines are your new additions to this notebook while the last two lines were already there from #168. It looks like I left the old default for path_nsidc (/glade/campaign/cesm/development/pcwg/ice/data/NSIDC_SeaIce_extent instead of the sudirectory of /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data that's used in the config.yml file for key_metrics); I'm all for updating to the new value, but can we either update path_nsidc where it was already declared or remove the old declarations of grid_file and path_nsidc down below?

"\n",
"lc_kwargs = {}\n",
"\n",
Expand Down
Loading