Skip to content

Commit b17555f

Browse files
chore(deps): update pre-commit hooks (pybind#5459)
* chore(deps): update pre-commit hooks updates: - [github.com/pre-commit/mirrors-clang-format: v19.1.3 → v19.1.4](pre-commit/mirrors-clang-format@v19.1.3...v19.1.4) - [github.com/astral-sh/ruff-pre-commit: v0.7.2 → v0.8.1](astral-sh/ruff-pre-commit@v0.7.2...v0.8.1) - [github.com/sirosen/texthooks: 0.6.7 → 0.6.8](sirosen/texthooks@0.6.7...0.6.8) - [github.com/PyCQA/pylint: v3.3.1 → v3.3.2](pylint-dev/pylint@v3.3.1...v3.3.2) - [github.com/python-jsonschema/check-jsonschema: 0.29.4 → 0.30.0](python-jsonschema/check-jsonschema@0.29.4...0.30.0) * Resolve ruff pre-commit errors: ``` ruff.....................................................................Failed - hook id: ruff - exit code: 1 warning: The following rules have been removed and ignoring them has no effect: - PT004 docs/benchmark.py:51:17: UP031 Use format specifiers instead of percent format | 50 | for cl in range(nclasses): 51 | decl += "class cl%03i {\n" % cl | ^^^^^^^^^^^^^^^^^^ UP031 52 | decl += "public:\n" 53 | bindings += f' py::class_<cl{cl:03}>("cl{cl:03}")\n' | = help: Replace with format specifiers docs/benchmark.py:88:15: UP031 Use format specifiers instead of percent format | 86 | elapsed = (n2 - n1).total_seconds() 87 | size = os.stat("test.so").st_size 88 | print(" {%i, %f, %i}," % (nclasses * nfns, elapsed, size)) | ^^^^^^^^^^^^^^^^^^ UP031 89 | print("}") | = help: Replace with format specifiers tools/make_changelog.py:62:9: PLC0206 Extracting value from dictionary without calling `.items()` | 61 | msg += f"\n `#{issue.number} <{issue.html_url}>`_" 62 | for cat in cats: | _________^ 63 | | if issue.title.lower().startswith(f"{cat}:"): 64 | | cats[cat].append(msg) 65 | | break 66 | | else: 67 | | cats["unknown"].append(msg) | |_______________________________________^ PLC0206 68 | 69 | for cat, msgs in cats.items(): | Found 3 errors. ``` --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
1 parent 1d09fc8 commit b17555f

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

.pre-commit-config.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ repos:
2525

2626
# Clang format the codebase automatically
2727
- repo: https://github.com/pre-commit/mirrors-clang-format
28-
rev: "v19.1.3"
28+
rev: "v19.1.4"
2929
hooks:
3030
- id: clang-format
3131
types_or: [c++, c, cuda]
3232

3333
# Ruff, the Python auto-correcting linter/formatter written in Rust
3434
- repo: https://github.com/astral-sh/ruff-pre-commit
35-
rev: v0.7.2
35+
rev: v0.8.1
3636
hooks:
3737
- id: ruff
3838
args: ["--fix", "--show-fixes"]
@@ -93,7 +93,7 @@ repos:
9393

9494
# Avoid directional quotes
9595
- repo: https://github.com/sirosen/texthooks
96-
rev: "0.6.7"
96+
rev: "0.6.8"
9797
hooks:
9898
- id: fix-ligatures
9999
- id: fix-smartquotes
@@ -142,14 +142,14 @@ repos:
142142

143143
# PyLint has native support - not always usable, but works for us
144144
- repo: https://github.com/PyCQA/pylint
145-
rev: "v3.3.1"
145+
rev: "v3.3.2"
146146
hooks:
147147
- id: pylint
148148
files: ^pybind11
149149

150150
# Check schemas on some of our YAML files
151151
- repo: https://github.com/python-jsonschema/check-jsonschema
152-
rev: 0.29.4
152+
rev: 0.30.0
153153
hooks:
154154
- id: check-readthedocs
155155
- id: check-github-workflows

docs/benchmark.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def generate_dummy_code_boost(nclasses=10):
4848
decl += "\n"
4949

5050
for cl in range(nclasses):
51-
decl += "class cl%03i {\n" % cl
51+
decl += f"class cl{cl:03} {{\n"
5252
decl += "public:\n"
5353
bindings += f' py::class_<cl{cl:03}>("cl{cl:03}")\n'
5454
for fn in range(nfns):
@@ -85,5 +85,5 @@ def generate_dummy_code_boost(nclasses=10):
8585
n2 = dt.datetime.now()
8686
elapsed = (n2 - n1).total_seconds()
8787
size = os.stat("test.so").st_size
88-
print(" {%i, %f, %i}," % (nclasses * nfns, elapsed, size))
88+
print(f" {{{nclasses * nfns}, {elapsed:.6f}, {size}}},")
8989
print("}")

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ ignore = [
7171
"PLR", # Design related pylint
7272
"E501", # Line too long (Black is enough)
7373
"PT011", # Too broad with raises in pytest
74-
"PT004", # Fixture that doesn't return needs underscore (no, it is fine)
7574
"SIM118", # iter(x) is not always the same as iter(x.keys())
7675
]
7776
unfixable = ["T20"]

tools/make_changelog.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@
5959
msg += "."
6060

6161
msg += f"\n `#{issue.number} <{issue.html_url}>`_"
62-
for cat in cats:
62+
for cat, cat_list in cats.items():
6363
if issue.title.lower().startswith(f"{cat}:"):
64-
cats[cat].append(msg)
64+
cat_list.append(msg)
6565
break
6666
else:
6767
cats["unknown"].append(msg)

0 commit comments

Comments
 (0)