Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing HomePage #1442

Open
wants to merge 50 commits into
base: ui/redesign
Choose a base branch
from
Open

Implementing HomePage #1442

wants to merge 50 commits into from

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Jan 14, 2025 •
edited
Loading

Closes #1429

TODO:

  • delete old code
  • logic of schedule card on top
  • rearrange button position
  • simplify save/delete favorite logic (?)
  • restaurant
  • onclick in functions
  • icons
  • fix misalignment when dragging cards
  • translations

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana changed the base branch from develop to ui/redesign January 14, 2025 15:55
@DGoiana
Copy link
Collaborator Author

DGoiana commented Jan 14, 2025

The first concern is the notch.

  • Without SafeArea():
  • With SafeArea():

@DGoiana DGoiana marked this pull request as draft January 20, 2025 15:07
@DGoiana
Copy link
Collaborator Author

DGoiana commented Jan 21, 2025

@DGoiana
Copy link
Collaborator Author

DGoiana commented Jan 31, 2025

Current state:

teste

@Adriano-7
Copy link
Member

Adriano-7 commented Feb 24, 2025 •
edited
Loading

I was testing it and noticed an overflow issue with the restaurant cards on my phone

@DGoiana
Copy link
Collaborator Author

DGoiana commented Mar 3, 2025

I was testing it and noticed an overflow issue with the restaurant cards on my phone

Thanks! Fixed already.

@DGoiana DGoiana marked this pull request as ready for review March 3, 2025 14:54
@DGoiana DGoiana requested a review from a team March 3, 2025 15:06
@codecov Codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.63158% with 444 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (e561fa9) to head (bd062cf).
Report is 1 commits behind head on ui/redesign.

❌ Your project check has failed because the head coverage (11%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##           ui/redesign   #1442   +/-   ##
===========================================
+ Coverage           11%     11%   +1%     
===========================================
  Files              270     270           
  Lines             7785    7727   -58     
===========================================
+ Hits               818     827    +9     
+ Misses            6967    6900   -67

Adriano-7
Adriano-7 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@Adriano-7 Adriano-7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Goiana! Really good code and a perfect result, congrats 🔥

There's some things i notice while testing that could be improved in the future (but maybe we should merge this PR and then work on those later to get the redesign off the ground ahah)

  • We should add some indication of days in the top widget and maybe the schedule cards

  • We lost the ability to refresh the page

  • @thePeras had an idea to further improve the ux of the edit page simply clicking on the item could immediatly add/drop them

  • There's a small white padding under the red

  • The professor's name when the class is happening still appears as Teacher X
  • The loading state could be improved (maybe by removing the red circle from the red part above and replacing the others by a block with a shimmer effect )

@DGoiana
Copy link
Collaborator Author

DGoiana commented Mar 4, 2025

Shimmer implementation:

thePeras
thePeras reviewed Mar 7, 2025
View reviewed changes
packages/uni_app/lib/view/home/widgets/restaurant_home_card.dart Outdated
return getRestaurantInformation(context, favoriteRestaurants)
.isNotEmpty;
},
onNullContent: const Text('Nenhum restaurante favorito aberto'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoded text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras left review comments

@Adriano-7 Adriano-7 Adriano-7 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Homepage
4 participants
@DGoiana @thePeras @Adriano-7 @Process-ing