Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign/translations #1482

Draft
wants to merge 1 commit into
base: ui/redesign
Choose a base branch
from
Draft

Redesign/translations #1482

wants to merge 1 commit into from

Conversation

Adriano-7
Copy link
Member

@Adriano-7 Adriano-7 commented Feb 19, 2025 •
edited
Loading

Closes #1461

Some notes:

  • This PR fixes the translation of courses and course_units
  • The calendar and the schedule links break when the page is /en, that's why i use the languageSensitive condition
  • The course unit sheet is still in portuguese eventhough the link is /en because the link we're using returns the info in portuguese
  • There's a problem with the abbreviation of finished courses (see the TODO). LEIC it appears as BICE

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@Adriano-7 Adriano-7 linked an issue Feb 19, 2025 that may be closed by this pull request
Handle translations #1461
Open
@Adriano-7 Adriano-7 requested review from thePeras and DGoiana and removed request for thePeras March 1, 2025 15:08
@Adriano-7 Adriano-7 changed the base branch from develop to ui/redesign March 1, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGoiana DGoiana Awaiting requested review from DGoiana

@thePeras thePeras Awaiting requested review from thePeras

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle translations
1 participant
@Adriano-7