Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add illustration to empty page #1508

Open
wants to merge 6 commits into
base: ui/redesign
Choose a base branch
from
Open

Add illustration to empty page #1508

wants to merge 6 commits into from

Conversation

jcovaa
Copy link
Contributor

@jcovaa jcovaa commented Mar 4, 2025 •
edited
Loading

Closes #1485

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@jcovaa jcovaa changed the base branch from develop to ui/redesign March 4, 2025 13:17
@jcovaa
Copy link
Contributor Author

jcovaa commented Mar 4, 2025 •
edited
Loading

Found this image but doesn't really fits in with the other images when there has no content.
The second image is other option of an image already been used.

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.93023% with 34 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (e561fa9) to head (a3473bc).
Report is 1 commits behind head on ui/redesign.

❌ Your project check has failed because the head coverage (11%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##           ui/redesign   #1508   +/-   ##
===========================================
+ Coverage           11%     11%   +1%     
===========================================
  Files              270     271    +1     
  Lines             7785    7804   +19     
===========================================
+ Hits               818     821    +3     
- Misses            6967    6983   +16

@DGoiana
Copy link
Collaborator

DGoiana commented Mar 4, 2025

Found this image but doesn't really fits in with the other images when there has no content. The second image is other option of an image already been used.

I prefer the first one, it looks cool!

@thePeras
Copy link
Member

thePeras commented Mar 7, 2025

Sorry to be annoying, but it is royalty free? Just to make sure we don't get troubles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add illustration to empty page
3 participants
@jcovaa @DGoiana @thePeras