-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #1494 . #1506
base: ui/redesign
Are you sure you want to change the base?
Fix for #1494 . #1506
Conversation
Fix the CI errors. |
/* OLD CODE: | ||
TabIcon(icon: UniIcons.course, text: Text(S.of(context).courses, overflow: TextOverflow.ellipsis),), TabIcon( | ||
icon: UniIcons.lecture, | ||
text: S.of(context).schedule, | ||
), | ||
TabIcon(icon: UniIcons.exam, text: S.of(context).exams),*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete!
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (11%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## ui/redesign #1506 +/- ##
===========================================
- Coverage 11% 11% -0%
===========================================
Files 270 270
Lines 7785 7799 +14
===========================================
Hits 818 818
- Misses 6967 6981 +14 🚀 New features to boost your workflow:
|
Closes #1494

Changed the tab structure to allow text overflow ellipsis. Left old code as comment for comparison.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change