Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1494 . #1506

Open
wants to merge 4 commits into
base: ui/redesign
Choose a base branch
from
Open

Fix for #1494 . #1506

wants to merge 4 commits into from

Conversation

AugustoVSoares
Copy link
Contributor

Closes #1494
Changed the tab structure to allow text overflow ellipsis. Left old code as comment for comparison.
imagem

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana
Copy link
Collaborator

DGoiana commented Mar 3, 2025

Fix the CI errors.

Comment on lines 58 to 63
/* OLD CODE:
TabIcon(icon: UniIcons.course, text: Text(S.of(context).courses, overflow: TextOverflow.ellipsis),), TabIcon(
icon: UniIcons.lecture,
text: S.of(context).schedule,
),
TabIcon(icon: UniIcons.exam, text: S.of(context).exams),*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete!

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (e561fa9) to head (143cd2c).
Report is 1 commits behind head on ui/redesign.

❌ Your project check has failed because the head coverage (11%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1506   +/-   ##
===========================================
- Coverage           11%     11%   -0%     
===========================================
  Files              270     270           
  Lines             7785    7799   +14     
===========================================
  Hits               818     818           
- Misses            6967    6981   +14     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants