Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: isActive account attribute #215

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

feature: isActive account attribute #215

wants to merge 13 commits into from

Conversation

peucastro
Copy link
Member

Closes #212

This PR aims to add an isActive flag to the Account entity in order to distinguish active members from inactive ones.

Review checklist

  • Behavior is as expected
  • Clean, well structured code
  • Properly documents API changes in the corresponding controller test
  • Contains enough appropriate tests
  • Changes are reflected in the Wiki if necessary

@peucastro peucastro added this to the Website MVP milestone Feb 12, 2025
@peucastro peucastro self-assigned this Feb 12, 2025
@peucastro peucastro removed this from the Website MVP milestone Feb 12, 2025
@peucastro
Copy link
Member Author

peucastro commented Feb 12, 2025 •
edited
Loading

Set isActive as true and mandatory by default and correct tests.

@github-actions GitHub Actions
Copy link

Check the documentation preview: https://67ae21ea2272281c2e04db64--niaefeup-backend-docs.netlify.app

@github-actions GitHub Actions
Copy link

Check the documentation preview: https://67ae2e7ecc5ae5ffc48fadfa--niaefeup-backend-docs.netlify.app

@peucastro peucastro marked this pull request as ready for review February 18, 2025 15:25
@github-actions GitHub Actions
Copy link

Check the documentation preview: https://67bdfcc1302f06e2d33df856--niaefeup-backend-docs.netlify.app

MRita443
MRita443 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Some non-essential comments but we can also close as is!

MRita443
MRita443 requested changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed, we should add isActive value checks to the rest of the tests in
AccountControllerTest to be thorough

@github-actions GitHub Actions
Copy link

Check the documentation preview: https://67bf0718484a9b3712231473--niaefeup-backend-docs.netlify.app

@github-actions GitHub Actions
Copy link

Check the documentation preview: https://67bf09f3fb32ff405f523456--niaefeup-backend-docs.netlify.app

@peucastro peucastro requested a review from MRita443 February 26, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRita443 MRita443 Awaiting requested review from MRita443

Requested changes must be addressed to merge this pull request.

Assignees

@peucastro peucastro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

account: add active attribute
2 participants
@peucastro @MRita443