Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored dto structure to reside in a single package #68

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

BrunoRosendo
Copy link
Member

closes #67

I decided to create the single DTO package in the global scope, since DTOs are used both in the controllers and in the services

Review checklist

  • Properly documents API changes in docs/openapi.yml
  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well structured code

@codecov-commenter
Copy link

Codecov Report

Base: 92.10% // Head: 91.83% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (fed15e5) compared to base (abba3d1).
Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #68      +/-   ##
=============================================
- Coverage      92.10%   91.83%   -0.27%     
- Complexity       162      167       +5     
=============================================
  Files             28       30       +2     
  Lines            342      343       +1     
  Branches          14       14              
=============================================
  Hits             315      315              
- Misses            16       17       +1     
  Partials          11       11              
Impacted Files Coverage Δ
...ni/website/backend/controller/AccountController.kt 100.00% <ø> (ø)
...fe/ni/website/backend/controller/AuthController.kt 100.00% <ø> (ø)
...e/ni/website/backend/controller/EventController.kt 100.00% <ø> (ø)
...fe/ni/website/backend/controller/PostController.kt 100.00% <ø> (ø)
...ni/website/backend/controller/ProjectController.kt 100.00% <ø> (ø)
...up/fe/ni/website/backend/service/AccountService.kt 100.00% <ø> (ø)
...t/up/fe/ni/website/backend/service/EventService.kt 100.00% <ø> (ø)
...pt/up/fe/ni/website/backend/service/PostService.kt 100.00% <ø> (ø)
...up/fe/ni/website/backend/service/ProjectService.kt 100.00% <ø> (ø)
...t/up/fe/ni/website/backend/dto/entity/EntityDto.kt 71.42% <20.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@BrunoRosendo BrunoRosendo merged commit 4b00e3f into develop Jan 4, 2023
@BrunoRosendo BrunoRosendo deleted the feature/dto-refactor branch January 4, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global: refactor DTO structure
4 participants