Fix title update issue

Author: SinghRajenM

src/NppJsonViewer/JsonViewDlg.cpp

@@ -67,12 +67,13 @@ void JsonViewDlg::ShowDlg(bool bShow)
         DrawJsonTree();
     }
 
-    UpdateTitle();
     DockingDlgInterface::display(bShow);
 }
 
 void JsonViewDlg::FormatJson()
 {
+    UpdateTitle();
+
     const auto selectedData = m_pEditor->GetJsonText();
     const auto selectedText = IsSelectionValidJson(selectedData);
 
@@ -103,6 +104,8 @@ void JsonViewDlg::FormatJson()
 
 void JsonViewDlg::CompressJson()
 {
+    UpdateTitle();
+
     const auto selectedData = m_pEditor->GetJsonText();
     const auto selectedText = IsSelectionValidJson(selectedData);
 
@@ -131,6 +134,8 @@ void JsonViewDlg::CompressJson()
 
 void JsonViewDlg::SortJsonByKey()
 {
+    UpdateTitle();
+
     const auto selectedData  = m_pEditor->GetJsonText();
     const auto selectedText = IsSelectionValidJson(selectedData);
 
@@ -287,13 +292,14 @@ void JsonViewDlg::HandleTabActivated()
             {
                 FormatJson();
             }
-            UpdateTitle();
         }
     }
 }
 
 void JsonViewDlg::ValidateJson()
 {
+    UpdateTitle();
+
     const auto selectedData  = m_pEditor->GetJsonText();
     const auto selectedText = IsSelectionValidJson(selectedData);
 
@@ -324,6 +330,8 @@ void JsonViewDlg::ValidateJson()
 
 void JsonViewDlg::DrawJsonTree()
 {
+    UpdateTitle();
+
     // Disable all buttons and treeView
     std::vector<DWORD> ctrls = {IDC_BTN_REFRESH, IDC_BTN_VALIDATE, IDC_BTN_FORMAT, IDC_BTN_SEARCH, IDC_EDT_SEARCH};
     EnableControls(ctrls, false);
@@ -526,28 +534,34 @@ void JsonViewDlg::SearchInTree()
 
 void JsonViewDlg::UpdateTitle()
 {
-    GetTitleFileName();
-    updateDockingDlg();
-}
-
-void JsonViewDlg::GetTitleFileName()
-{
-    if (!m_pCurrFileName)
+    const auto titleFileName = GetTitleFileName();
+    if (!titleFileName.empty())
     {
-        m_pCurrFileName = std::make_unique<wchar_t[]>(FILENAME_LEN_IN_TITLE);
+        if (!m_pCurrFileName)
+        {
+            m_pCurrFileName = std::make_unique<wchar_t[]>(FILENAME_LEN_IN_TITLE);
+        }
+
+        if (_wcsicmp(m_pCurrFileName.get(), titleFileName.c_str()) != 0)
+        {
+            memset(m_pCurrFileName.get(), 0, FILENAME_LEN_IN_TITLE);
+            wcsncpy_s(m_pCurrFileName.get(), FILENAME_LEN_IN_TITLE, titleFileName.c_str(), _TRUNCATE);
+
+            updateDockingDlg();
+        }
     }
+}
 
+auto JsonViewDlg::GetTitleFileName() const -> std::wstring
+{
     auto currFile = m_pEditor->GetCurrentFileName();
     if (currFile.length() >= FILENAME_LEN_IN_TITLE)
     {
         // If the filename is too long, truncate it and add "..."
         currFile = currFile.substr(0, FILENAME_LEN_IN_TITLE - 4) + L"...";
     }
 
-    memset(m_pCurrFileName.get(), 0, FILENAME_LEN_IN_TITLE);
-    wcsncpy_s(m_pCurrFileName.get(), FILENAME_LEN_IN_TITLE, currFile.c_str(), _TRUNCATE);
-
-    updateDockingDlg();
+    return currFile;
 }
 
 void JsonViewDlg::PrepareButtons()

src/NppJsonViewer/JsonViewDlg.h

@@ -54,7 +54,7 @@ class JsonViewDlg : public DockingDlgInterface
 
     void SearchInTree();
 
-    void GetTitleFileName();
+    auto GetTitleFileName() const -> std::wstring;
     void PrepareButtons();
     void SetIconAndTooltip(eButton ctrlType, const std::wstring &toolTip);