Add async aggregator #3455
Open
Add async aggregator #3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| with _update_lock: | ||
| new_ctx = FLContext() | ||
| new_ctx.model = self.model |
There was a problem hiding this comment.
no related to this PR, but are we using this "self.model" anywhere?
Comment on lines
+155
to
+156
| if rc != _AcceptWaitRC.IS_SET: | ||
| self.log_warning(fl_ctx, f"abnormal result {rc} waiting for accept thread") |
There was a problem hiding this comment.
if the accept thread has "abnormal" RC, should we just return here? or raise Exception?
There was a problem hiding this comment.
This could only happen when the "accept" thread is timed out (e.g. the original aggregator's accept method got stuck). I think you are right that we should raise exception, since there won't be a good way to recover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
This PR implements a wrapper aggregator that can be used to perform another aggregator's "accept" method in a separate thread. This can drastically reduce the block time of the SAG workflow when processing client submission if the "accept" processing is time-consuming, as reported by some customers.
To use this aggregator, the user simply puts the original aggregator as a component in this wrapper aggregator (AsyncAggregator):
"components": [
{
"id": "aggregator",
"path": "nvflare.app_common.aggregators.intime_accumulate_model_aggregator.InTimeAccumulateWeightedAggregator",
"args": {
"expected_data_kind": "WEIGHTS"
}
},
{
"id": "aggr_wrapper",
"path": "nvflare.app_common.aggregators.async.AsyncAggregator",
"args": {
"aggregator_id": "aggregator"
}
},
...
],
"workflows": [
{
"id": "scatter_and_gather",
"path": "nvflare.app_common.workflows.scatter_and_gather.ScatterAndGather",
"args": {
"min_clients": "{min_clients}",
"num_rounds": 2,
"start_round": 0,
"wait_time_after_min_received": "{wait_time}",
"aggregator_id": "aggr_wrapper",
"persistor_id": "persistor",
"shareable_generator_id": "shareable_generator",
"train_task_name": "train",
"train_timeout": 6000,
"ignore_result_error": true
}
}
]
Types of changes
./runtest.sh.