Add Korean TN support for cardinal numbers #280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
for more information, see https://pre-commit.ci
mgrafu
reviewed
May 12, 2025
|
|
||
| # 1-99 reading | ||
| read_1_to_99 = pynini.union(read_1, read_10_to_19, read_20_to_99).optimize() | ||
| read_100_to_999 = (NEMO_DIGIT**3) @ graph_hundred_component |
There was a problem hiding this comment.
is this different from line 66?
mgrafu
reviewed
May 12, 2025
| graph_thousand = thousands @ graph_thousand_component | ||
|
|
||
| # 1-99 reading | ||
| read_1_to_99 = pynini.union(read_1, read_10_to_19, read_20_to_99).optimize() |
There was a problem hiding this comment.
is this different from line 44?
mgrafu
reviewed
May 12, 2025
| graph_10_to_19 = graph_teen | ||
| graph_20_to_99 = graph_ty | ||
|
|
||
| graph_all = pynini.union( |
There was a problem hiding this comment.
let's use a more descriptive name for this variable
There was a problem hiding this comment.
I updated the variable names and used a new logic for the creation part.
mgrafu
reviewed
May 12, 2025
| # 1-99 reading | ||
| read_1_to_99 = pynini.union(read_1, read_10_to_19, read_20_to_99).optimize() | ||
| read_100_to_999 = (NEMO_DIGIT**3) @ graph_hundred_component | ||
| read_1000_to_9999 = (NEMO_DIGIT**4) @ graph_thousand_component |
There was a problem hiding this comment.
is this different from line 78?
Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
…l.py Signed-off-by: Jinwoo Bae <34386414+bbae0312@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
Superseded by #285. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds support for Korean cardinal number text normalization (TN), including:
Notes
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.