Skip to content

[OAI Serving] Validate greedy generation args #13113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

jenchen13
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

For NeMo OAI serving, validate greedy generation arguments in the request to be compatible with core-eval/nv_eval, which only exposes temperature and top_p arguments. If temperature=0 and top_p=0 in core-eval, then top_k by default is 0 in OAI serving which will cause an error in megatron-core generation.

Collection: [Note which collection this PR will affect]

Changelog

  • add a Pydantic model validator for CompletionRequest which checks if temperature=0 and top_p=0 and sets top_k=1 if True.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: jenchen13 <jennifchen@nvidia.com>
@jenchen13 jenchen13 requested a review from athitten April 18, 2025 18:57
Signed-off-by: jenchen13 <jennifchen@nvidia.com>
@jenchen13 jenchen13 requested a review from marta-sd April 22, 2025 13:32
Copy link
Collaborator

@marta-sd marta-sd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jenchen13 jenchen13 enabled auto-merge (squash) April 23, 2025 14:07
Copy link
Collaborator

@athitten athitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @jenchen13 !

@athitten athitten added the r2.3.0 Pick this label for auto-cherrypicking into v2.3.0 label Apr 23, 2025
@jenchen13 jenchen13 merged commit 020d289 into main Apr 23, 2025
57 checks passed
@jenchen13 jenchen13 deleted the jennifchen/oai_validate_args branch April 23, 2025 19:03
ko3n1g pushed a commit that referenced this pull request Apr 23, 2025
* validate greedy generation args

Signed-off-by: jenchen13 <jennifchen@nvidia.com>
chtruong814 added a commit that referenced this pull request Apr 23, 2025
This reverts commit 020d289.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814 added a commit that referenced this pull request Apr 23, 2025
This reverts commit 020d289.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@jenchen13 jenchen13 restored the jennifchen/oai_validate_args branch April 23, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r2.3.0 Pick this label for auto-cherrypicking into v2.3.0 Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants