-
Notifications
You must be signed in to change notification settings - Fork 314
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This change copies ldconfig into a memfd before executing it from the createContainer hook. Signed-off-by: Evan Lezar <elezar@nvidia.com>
- Loading branch information
Showing
35 changed files
with
4,010 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /** | ||
| # Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| **/ | ||
|
|
||
| package ldcache | ||
|
|
||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
|
|
||
| "github.com/moby/sys/symlink" | ||
| ) | ||
|
|
||
| // A containerRoot represents the root filesystem of a container. | ||
| type containerRoot string | ||
|
|
||
| // hasPath checks whether the specified path exists in the root. | ||
| func (r containerRoot) hasPath(path string) bool { | ||
| resolved, err := r.resolve(path) | ||
| if err != nil { | ||
| return false | ||
| } | ||
| if _, err := os.Stat(resolved); err != nil && os.IsNotExist(err) { | ||
| return false | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| // globFiles matches the specified pattern in the root. | ||
| // The files that match must be regular files. | ||
| func (r containerRoot) globFiles(pattern string) ([]string, error) { | ||
| patternPath, err := r.resolve(pattern) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| matches, err := filepath.Glob(patternPath) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| var files []string | ||
| for _, match := range matches { | ||
| info, err := os.Lstat(match) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| // Ignore symlinks. | ||
| if info.Mode()&os.ModeSymlink != 0 { | ||
| continue | ||
| } | ||
| // Ignore directories. | ||
| if info.IsDir() { | ||
| continue | ||
| } | ||
| files = append(files, match) | ||
| } | ||
| return files, nil | ||
| } | ||
|
|
||
| // resolve returns the absolute path including root path. | ||
| // Symlinks are resolved, but are guaranteed to resolve in the root. | ||
| func (r containerRoot) resolve(path string) (string, error) { | ||
| absolute := filepath.Clean(filepath.Join(string(r), path)) | ||
| return symlink.FollowSymlinkInScope(absolute, string(r)) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /** | ||
| # Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| **/ | ||
|
|
||
| package ldcache | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "strconv" | ||
| "syscall" | ||
|
|
||
| "github.com/opencontainers/runc/libcontainer/dmz" | ||
| ) | ||
|
|
||
| func SafeExec(path string, args []string, envv []string) error { | ||
| safeExe, err := cloneBinary(path) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to clone binary: %w", err) | ||
| } | ||
| defer safeExe.Close() | ||
|
|
||
| exePath := "/proc/self/fd/" + strconv.Itoa(int(safeExe.Fd())) | ||
|
|
||
| //nolint:gosec // TODO: Can we harden this so that there is less risk of command injection | ||
| return syscall.Exec(exePath, args, envv) | ||
| } | ||
|
|
||
| func cloneBinary(path string) (*os.File, error) { | ||
| exe, err := os.Open(path) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("opening current binary: %w", err) | ||
| } | ||
| defer exe.Close() | ||
|
|
||
| stat, err := exe.Stat() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("checking /proc/self/exe size: %w", err) | ||
| } | ||
| size := stat.Size() | ||
|
|
||
| return dmz.CloneBinary(exe, size, path, os.TempDir()) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| //go:build !linux | ||
| // +build !linux | ||
|
|
||
| /** | ||
| # Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| **/ | ||
|
|
||
| package ldcache | ||
|
|
||
| import "syscall" | ||
|
|
||
| func SafeExec(path string, args []string, envv []string) error { | ||
| return syscall.Exec(path, args, envv) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.