Use empty string for default runtime-config-override #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that we unnecessarily print warnings for runtimes where these configs are not applicable. This removes the following warnings: WARN[0000] Ignoring runtime-config-override flag for docker Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
klueska
approved these changes
Aug 21, 2024
cdesiniotis
approved these changes
Aug 21, 2024
tariq1890
reviewed
Aug 22, 2024
| @@ -100,7 +100,7 @@ func TestMounts(t *testing.T) { | |||
| lookup: &lookup.LocatorMock{ | |||
| LocateFunc: func(s string) ([]string, error) { | |||
| if s == "error" { | |||
| return nil, fmt.Errorf(s) | |||
| return nil, fmt.Errorf("error") | |||
There was a problem hiding this comment.
nit: (Optional) If we are using constant strings, we can use the stdlib errors.New instead. Also we need a better error message than just error as it doesn't say much. I understand that it's a test case, but expressive error messages also help us better debug and trace unit test failures
Suggested change
| return nil, fmt.Errorf("error") | |
| return nil, fmt.Errorf("error") |
There was a problem hiding this comment.
Those are all valid points. Since this is a cherry-pick, I'm not going to address these here and would prefer to keep the functionality the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks #658
Fixes #631