DSD-1901: Remove role="search" from Searchbar

[7emansell]

Fixes JIRA ticket DSD-1901

This PR does the following:

• Removes search role from Searchbar component wrapper
• Updates tests, docs

How has this been tested?

Accessibility concerns or updates

• Accessibility update meant to allow devs to set search landmark correctly (usually includes more elements than just the Searchbar)

Accessibility Checklist

• Checked Storybook's "Accessibility" tab for color contrast and other issues.
• The feature works with keyboard inputs including tabbing back and forward and pressing space, enter, arrow, and esc keys.
• For hidden text or when aria-live is used, a screenreader was used to verify the text is read.
• For features that involve UI updates and focusing on DOM refs, focus management was reviewed.
• The feature works when the page is zoomed in to 200% and 400%.

Open Questions

Checklist:

• I have updated the Storybook documentation and changelog accordingly.
• I have added relevant accessibility documentation for this pull request.
• All new and existing tests passed.

Front End Review:

• Review the Vercel preview deployment once it is ready.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nypl-design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2025 6:06pm

[EdwinGuzman]

All looks good, but a minor request on the doc page.

[EdwinGuzman]

Since you're already updating this doc page.... can you include the new layout styles? Use the ComponentDocsHeader component and check Banner (https://nypl-design-system-git-reservoir-v4-nypl.vercel.app/?path=/docs/components-feedback-banner--docs) for an example of the new order for storybook doc pages.

[7emansell]

🤨 Don't know if this is a valid summary

[EdwinGuzman]

Or something along the lines of "a multi-component based UI for searching..." @bigfishdesign13 ?

[EdwinGuzman]

I'm not too concern about the summary right now.

[EdwinGuzman]

Or something along the lines of "a multi-component based UI for searching..." @bigfishdesign13 ?

[oliviawongnyc]

This looks good to me, but the ticket says "document how should be used instead." Does this mean should be used instead of role="search"? Are we no longer recommending that?

[7emansell]

This looks good to me, but the ticket says "document how should be used instead." Does this mean should be used instead of role="search"? Are we no longer recommending that?

We're still recommending using role = search (in #1806) but rarely (if ever) would it be correctly used on just the Searchbar component, so we want to stop enforcing that incorrect usage @oliviawongnyc