Add Asset Builder to BuildCommand #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #493 - Verifies the presence of npm scripts - If present, prompts the user to choose a script to run prior to building/publishing NativePHP app. - Build command is optional and not necessarily required
- Specify `--assets` to build assets - If --asset-build is unspecified, we'll try to run `npm run build`. - A specific build command can be specified like so `--asset-build=my-build-command`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NativePHP/laravel#493
This pull request introduces a new trait to manage asset building in the
BuildCommandclass, alongside several related changes to support this functionality. The most important changes include adding theManagesAssetBuildingtrait, updating theBuildCommandclass to use this trait, and implementing methods to detect and run NPM scripts.Enhancements to Build Command:
src/Commands/BuildCommand.php: Added theManagesAssetBuildingtrait and updated the command signature to include options for building assets. To build assets, you can supply the--assetsoption. It will default to runningnpm run build. Ifbuildis not the correct script name, it can be overridden like so:--asset-build=my-scriptsrc/Commands/BuildCommand.php: Modified thehandlemethod to check and build project assets if the--assetsoption is provided.New Trait for Asset Management:
src/Traits/ManagesAssetBuilding.php: Introduced a new traitManagesAssetBuildingthat includes methods to detect NPM scripts, prompt for a build command, and run the selected NPM script.