Fix: Return type mismatch between screen facade and screen class methods. #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kondi3
deleted the
fix/return-type-mismatch-in-screen-and-screen-facade
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes method return type mismatches between the
Native\Laravel\Facades\Screenfacade andNative\Laravel\Screenclass.Before, when a method was called using the facade that had a return type mismatch, it would cause a TypeError, refer to screenshot below.
This fix changed the return types on methods in the
Native\Laravel\Screenclass to match their corresponding method signature in theNative\Laravel\Facades\Screenfacade as this did not introduce new issues in current code that is using the methods in question which are listed below.Native\Laravel\Screen::primary()Native\Laravel\Screen::active()