Skip to content

Commit 0f0a501

Browse files
committed
chore: feedback
1 parent 501c8cd commit 0f0a501

File tree

8 files changed

+17
-22
lines changed

8 files changed

+17
-22
lines changed

apps/nativescript-demo-ng/src/app/item/items.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { ModalDialogService, NativeDialogService, NativeScriptCommonModule } fro
1515
schemas: [NO_ERRORS_SCHEMA]
1616
})
1717
export class ItemsComponent implements OnInit, OnDestroy {
18-
message = 'Hello Angular 19!';
18+
message = 'Hello Angular 20.0.0-rc.1!';
1919
items: Array<Item>;
2020

2121
constructor(

apps/nativescript-demo-ng/src/app/item3/items.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { ModalDialogService, NativeDialogService, NativeScriptCommonModule, Nati
1515
schemas: [NO_ERRORS_SCHEMA]
1616
})
1717
export class ItemsComponent implements OnInit, OnDestroy {
18-
message = 'Hello Angular 19';
18+
message = 'Hello Angular 20.0.0-rc.1';
1919
items: Array<Item>;
2020
borderRadius: number;
2121
fontSize: number;

apps/nativescript-demo-ng/src/app/modal/modal.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<GridLayout [backgroundColor]="'#d63681'" rows="*,auto,auto">
22
<!-- <Image [src]="logo" stretch="aspectFit" width="200" marginTop="50" /> -->
3-
<Image src="~/assets/ng-18.png" stretch="aspectFit" (loaded)="loadedImg($event)" class="w-full" />
3+
<Image src="~/assets/ng-20.png" stretch="aspectFit" (loaded)="loadedImg($event)" class="w-full" />
44

55
<!-- @if (this.itemService.currentFlavor + 1 !== this.itemService.flavors.length) {
66
<Button row="1" (tap)="openNewModal()" text="Taste Another" fontSize="20" borderRadius="25"></Button>
125 KB
Loading

apps/nativescript-demo-ng/src/main.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ import { withInterceptorsFromDi } from '@angular/common/http';
1212
import { setWindowBackgroundColor } from '@nativescript/core/utils/ios';
1313
import { AppComponent } from './app/app.component';
1414
import { routes } from './app/app.routes';
15-
import { provideZoneChangeDetection } from '@angular/core';
15+
import { provideZonelessChangeDetection } from '@angular/core';
1616

17-
const EXPERIMENTAL_ZONELESS = true;
17+
const ZONELESS = true;
1818

1919
Trace.enable();
2020
Trace.setCategories('ns-route-reuse-strategy,ns-router');
@@ -28,7 +28,7 @@ runNativeScriptAngularApp({
2828
providers: [
2929
provideNativeScriptHttpClient(withInterceptorsFromDi()),
3030
provideNativeScriptRouter(routes),
31-
EXPERIMENTAL_ZONELESS ? provideZoneChangeDetection() : provideNativeScriptNgZone(),
31+
ZONELESS ? provideZonelessChangeDetection() : provideNativeScriptNgZone(),
3232
],
3333
});
3434
},

apps/nativescript-demo-ng/src/polyfills.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,15 @@
66
import '@nativescript/core/globals';
77
// Install @nativescript/angular specific polyfills
88
import '@nativescript/angular/polyfills';
9-
import { AbortController, AbortSignal } from '@nativescript/core/abortcontroller';
10-
(global as any).AbortController = AbortController;
11-
(global as any).AbortSignal = AbortSignal;
129
/**
1310
* Zone.js and patches
1411
*/
1512
// Add pre-zone.js patches needed for the NativeScript platform
1613
import '@nativescript/zone-js/dist/pre-zone-polyfills';
1714

18-
// Zone JS is required by default for Angular itself
19-
import 'zone.js';
15+
// Uncomment if using zone:
16+
// // Zone JS is required by default for Angular itself
17+
// import 'zone.js';
2018

21-
// Add NativeScript specific Zone JS patches
22-
import '@nativescript/zone-js';
19+
// // Add NativeScript specific Zone JS patches
20+
// import '@nativescript/zone-js';
Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,8 @@
11
const webpack = require('@nativescript/webpack');
2-
const { ProvidePlugin } = require("webpack");
32

43
module.exports = (env) => {
54
webpack.init(env);
65
webpack.useConfig('angular');
76

8-
webpack.chainWebpack((config) => {
9-
config.resolve.set('fallback', {
10-
AbortController: require.resolve('@nativescript/core/abortcontroller'),
11-
AbortSignal: require.resolve('@nativescript/core/abortcontroller'),
12-
});
13-
});
14-
157
return webpack.resolveConfig();
168
};
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
import { AbortController, AbortSignal } from '@nativescript/core/abortcontroller';
2+
3+
(global as any).AbortController = AbortController;
4+
(global as any).AbortSignal = AbortSignal;
5+
16
export const disabledPatches = ['legacy', 'EventTarget', 'XHR', 'MutationObserver', 'IntersectionObserver', 'FileReader'];
27

38
for (const patch of disabledPatches) {
@@ -6,4 +11,4 @@ for (const patch of disabledPatches) {
611

712
if (typeof queueMicrotask === 'undefined') {
813
global.queueMicrotask = (cb) => Promise.resolve().then(cb);
9-
}
14+
}

0 commit comments

Comments
 (0)