Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tomllib to directories copied for Python zip. #994

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

This just adds the tomllib directory to the list used to create the python zipfile. It appears that get-pip now appears to need tomllib and the installer build started failing because it was missing. Adding the directory fixed the "ModuleNotFoundError: No module named 'tomllib'" failure in get-pip.

Have you tested your changes (if applicable)? If so, how?

Yes. I've verified the installer builds successfully again with this fix.

Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolwell acolwell merged commit 03bb039 into NatronGitHub:RB-2.6 Jul 30, 2024
3 checks passed
@acolwell acolwell deleted the add_tomllib_to_pythonzip branch July 30, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants