Unique IDs for record images (LIV) #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Records and images actually have a many-to-many relationship, but here it's been defined as a one-to-many; using the url as an id for the image was causing subsequent references to the same image to overwrite the previous record associations, so some records did not have any images. This also caused long loading times because the image would be requested for every record but only shown for the last. Using an id that is unique to the resource, record, and image means that images are repeated but that's probably clearer anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records and images actually have a many-to-many relationship, but on the LIV it's been defined as a one-to-many; using the URL as an ID for the image was causing subsequent references to the same image to overwrite the previous record associations, so some records did not have any images (or at least were missing some of their images).
This also caused long loading times because the image would be requested for every record but only shown for the last. Using an ID that is unique to the resource, record, and image means that images are repeated but that's probably clearer anyway.