Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch errors when parsing lat/lon for individual records #775

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: catch errors when parsing lat/lon for individual records #775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ckanext/nhm/lib/record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,12 +397,12 @@ def geojson(self) -> Optional[dict]:
if not lat_field or not lon_field:
return None

latitude = self.data.get(lat_field)
longitude = self.data.get(lon_field)

if latitude is None or longitude is None:
try:
latitude = float(self.data.get(lat_field))
longitude = float(self.data.get(lon_field))
except (ValueError, TypeError):
return None

# create a piece of GeoJSON to point at the specific record location on a map (note the
# longitude then latitude ordering required by GeoJSON)
return dict(type='Point', coordinates=[float(longitude), float(latitude)])
# create a piece of GeoJSON to point at the specific record location on a map
# (note the longitude then latitude ordering required by GeoJSON)
return dict(type="Point", coordinates=[longitude, latitude])
Loading