Skip to content

Rename addBlob!(..., filepath::AbstractString, ... ) to uploadFile and implement addBlob! that matches the api #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Affie opened this issue Oct 23, 2024 · 2 comments

Comments

@Affie
Copy link
Member

Affie commented Oct 23, 2024

          We should rather call this `uploadFile` and have an `addBlob!` that matches the api. 

I haven't had a use case for uploadFile yet, but it's good to have as I can see some uses.

Originally posted by @Affie in #264 (comment)

@dehann
Copy link
Member

dehann commented Oct 23, 2024

Old addBlob! Is still there unchanged. This is a different signature. Signature parameter tells user it's a file. End result is still that a blob was added.

@Affie
Copy link
Member Author

Affie commented Mar 18, 2025

To work seamlessly across the different back-ends signatures such as addBlob! should look the same, ie. addBlob!(store::AbstractBlobStore, blobId::UUID, blob)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants