Skip to content

Commit

Permalink
Merge pull request #23 from NeowayLabs/fix-is-valid-message-merge-master
Browse files Browse the repository at this point in the history
fix: Fix IsValidMessage method adding a new exception for merge from master to the branch
  • Loading branch information
esequielvirtuoso authored Apr 2, 2024
2 parents 247ac03 + abfdc33 commit 83eb060
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
v2.0.3:
- Fix IsValidMessage method adding a new exception for merge from master to the branch (@esequiel.virtuoso)

v2.0.2:
- Fix IsValidMessage method adding a new exception for merge from master to the branch (@esequiel.virtuoso)

Expand Down
8 changes: 7 additions & 1 deletion src/commit-message/commit_message_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ func isMergeMasterToBranch(message string) bool {
splitedMessage := strings.Split(strings.ToLower(message), "\n")

for _, row := range splitedMessage {
if strings.Contains(row, "'origin/master' into") || strings.Contains(row, "merge branch 'master' into") {
lowerRow := strings.ToLower(row)
if strings.Contains(lowerRow, "'origin/master' into") ||
strings.Contains(lowerRow, "merge branch 'master' into") ||
strings.Contains(lowerRow, "merge branch 'master' of") ||
strings.Contains(lowerRow, "'origin/main' into") ||
strings.Contains(lowerRow, "merge branch 'main' into") ||
strings.Contains(lowerRow, "merge branch 'main' of") {
return true
}
}
Expand Down
16 changes: 16 additions & 0 deletions src/commit-message/commit_message_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,20 @@ func TestIsValidMessageMergeMasterBranchSuccess(t *testing.T) {
message = "first message row \n Merge branch 'master' into something \n last message row"
actual = f.commitMessageManager.IsValidMessage(message)
tests.AssertTrue(t, actual)

message = "first message row \n Merge branch 'master' of something \n last message row"
actual = f.commitMessageManager.IsValidMessage(message)
tests.AssertTrue(t, actual)

message = "first message row \n Merge remote-tracking branch 'origin/main' into something \n last message row"
actual = f.commitMessageManager.IsValidMessage(message)
tests.AssertTrue(t, actual)

message = "first message row \n Merge branch 'main' into something \n last message row"
actual = f.commitMessageManager.IsValidMessage(message)
tests.AssertTrue(t, actual)

message = "first message row \n Merge branch 'main' of something \n last message row"
actual = f.commitMessageManager.IsValidMessage(message)
tests.AssertTrue(t, actual)
}

0 comments on commit 83eb060

Please sign in to comment.