-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(template): prevent default values from overriding props #17167
Conversation
44cc4a0
to
6f21eb8
Compare
之前不会走到这个逻辑分支是因为前面有个 |
6f21eb8
to
44e1750
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢贡献。o is string -> o is boolean,这个改动是什么原因 @erweixin
e618f9f
to
20828a6
Compare
这个是不需要更改。修正了。 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17167 +/- ##
========================================
Coverage 58.52% 58.52%
========================================
Files 468 468
Lines 27136 27136
Branches 5939 5712 -227
========================================
Hits 15882 15882
+ Misses 9802 9771 -31
- Partials 1452 1483 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
这个 PR 做了什么? (简要描述所做更改)
当默认值为
true
时,props value
设置为false
不会生效原代码类似:
更改为
没有使用
??
是因为小程序暂时不支持,使用需要项目转为 es5。这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: