Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(solid): 引入第三方库,若该库引入了solid相关包(solid-js、@tarojs/plugin-framework-solid/dist/reconciler...)统一幻影依赖到业务侧 #17362

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

phy-lei
Copy link
Contributor

@phy-lei phy-lei commented Feb 22, 2025

这个 PR 做了什么? (简要描述所做更改)

  • 🐛bugfix: 修复Portal组件使用报错问题
  • 🚀feat: 引入第三方库,若该库引入了solid相关包(solid-js、@tarojs/plugin-framework-solid/dist/reconciler...)统一幻影依赖到业务侧,兼容第三方库使用external solid场景,减少包体积。

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来没什么问题 @tutuxxx 杰哥帮忙审下~

Copy link
Contributor

@yusjie yusjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@yusjie
Copy link
Contributor

yusjie commented Feb 24, 2025

外观没什么问题@tutuxxx杰哥帮忙下~

嘶,你是不是发错人了。。。

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (8c5d87b) to head (607a721).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17362   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files         468      468           
  Lines       27136    27136           
  Branches     5942     5954   +12     
=======================================
  Hits        15882    15882           
- Misses       9745     9803   +58     
+ Partials     1509     1451   -58     
Flag Coverage Δ
taro-cli 72.37% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 52.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@tutuxxx tutuxxx self-requested a review February 25, 2025 06:00
@tutuxxx tutuxxx merged commit 34eee4c into NervJS:main Feb 25, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants